Add response_sensitive support for resource, data source, and ephemeral - #155
Merged
Conversation
Port optional sensitive response attributes from #144 onto current main, integrate with Create/Read sanitization from #154, and extend coverage to data source and ephemeral open/renew/close responses. Supersedes #144. Closes #142. Co-authored-by: Dan Hansen <dan@recidiviz.org> Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 20, 2026
Contributor
|
Thank you!! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response_sensitiveand sensitive response attributes toterracurl_requestresource, data source, and ephemeral resourcesensitive_*computed attributes when enabled so secrets are redacted in plan outputsanitizeResponse()from Fix Create() response sanitization to match Read() #154 on the managed resourcesensitive_response,sensitive_renew_response,sensitive_close_response)Supersedes #144. Closes #142.
Thanks to @ohaibbq for the original report, design, and resource tests. This PR extends the feature to data source and ephemeral resources beyond the original #144 scope.
Test plan
go build ./...TF_ACC=1 go test ./internal/provider/... -count=1go generate ./...Made with Cursor